Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baremetal): add support for ipam ips #2769

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 10, 2024

No description provided.

@yfodil yfodil added vpc Virtual Private Cloud (VPC) issues, bugs and feature requests baremetal labels Oct 10, 2024
@yfodil yfodil self-assigned this Oct 10, 2024
@github-actions github-actions bot added load-balancer Load-balancer issues, bugs and feature requests iam IAM issues, bugs and feature requests labels Oct 10, 2024
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Oct 10, 2024
@github-actions github-actions bot added the flexible-ip Flexible IP issues, bugs and feature requests label Oct 15, 2024
@yfodil yfodil marked this pull request as ready for review October 15, 2024 14:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 88.13559% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (fe86049) to head (3955855).
Report is 204 commits behind head on master.

Files with missing lines Patch % Lines
internal/locality/regional/ids.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2769      +/-   ##
==========================================
- Coverage   71.43%   71.15%   -0.28%     
==========================================
  Files         277      328      +51     
  Lines       35875    32923    -2952     
==========================================
- Hits        25628    23427    -2201     
+ Misses       8028     7250     -778     
- Partials     2219     2246      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Oct 17, 2024
Merged via the queue into scaleway:master with commit 3617200 Oct 17, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baremetal flexible-ip Flexible IP issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants