Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add user tags option #2770

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Oct 11, 2024

No description provided.

@Monitob Monitob requested a review from Codelax as a code owner October 11, 2024 09:31
@github-actions github-actions bot added the iam IAM issues, bugs and feature requests label Oct 11, 2024
@Monitob Monitob requested a review from remyleone as a code owner October 11, 2024 09:44
@remyleone remyleone marked this pull request as draft October 17, 2024 09:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (fe86049) to head (29af424).
Report is 228 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/iam/user.go 79.31% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2770      +/-   ##
==========================================
- Coverage   71.43%   67.70%   -3.73%     
==========================================
  Files         277      339      +62     
  Lines       35875    40003    +4128     
==========================================
+ Hits        25628    27085    +1457     
- Misses       8028    10602    +2574     
- Partials     2219     2316      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review November 26, 2024 10:25
@remyleone remyleone changed the title Feat: add user tags option feat(iam): add user tags option Nov 26, 2024
@remyleone remyleone enabled auto-merge November 26, 2024 10:29
@remyleone remyleone added this pull request to the merge queue Nov 26, 2024
Merged via the queue into scaleway:master with commit 50aef3f Nov 26, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iam IAM issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants