Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lb): mark certificate chain as sensitive #2771

Merged

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 11, 2024

No description provided.

@yfodil yfodil added bug load-balancer Load-balancer issues, bugs and feature requests labels Oct 11, 2024
@yfodil yfodil self-assigned this Oct 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.12%. Comparing base (fe86049) to head (d6d3dbe).
Report is 200 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2771      +/-   ##
==========================================
- Coverage   71.43%   71.12%   -0.32%     
==========================================
  Files         277      328      +51     
  Lines       35875    32917    -2958     
==========================================
- Hits        25628    23412    -2216     
+ Misses       8028     7254     -774     
- Partials     2219     2251      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Oct 11, 2024
Merged via the queue into scaleway:master with commit 5382393 Oct 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug load-balancer Load-balancer issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaleway_lb_certificate.custom_certificate.certificate_chain is not marked as sensitive
3 participants