feat(mongodb): add support for v1alpha1 #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jremy42
force-pushed
the
feat/add_support_for_mondoDB
branch
from
4bed7e2 to
22c5348
Compare
remyleone
changed the title
jremy42
changed the title
jremy42
changed the title
jremy42
force-pushed
the
feat/add_support_for_mondoDB
branch
4 times, most recently
from
e118e28 to
ce3f07c
Compare
remyleone
reviewed
Oct 23, 2024
| "user_name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, |
There was a problem hiding this comment.
Does that mean that changing the name of a user_name will imply the recreation of the whole instance?
There was a problem hiding this comment.
Yes, the user_name cannot be updated at the moment, so changing it will indeed trigger the recreation of the whole instance.
There was a problem hiding this comment.
doing nothing be a better solution?
There was a problem hiding this comment.
Maybe having a dedicated resource for user, it is early but I would feel more comfortable with that rather than having a forcenew that could have large consequences if handled badly
| }, | ||
| }, | ||
| "node_number": { | ||
| Type: schema.TypeInt, |
| updateUserRequest.Password = &password | ||
| } | ||
|
|
||
| if updateUserRequest.Password != nil { |
There was a problem hiding this comment.
Same here, introduce a variable and check this variable to ensure than an update should be performed
jremy42
force-pushed
the
feat/add_support_for_mondoDB
branch
from
8e36460 to
fe47373
Compare
remyleone
reviewed
Oct 24, 2024
remyleone
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.