Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipam): support custom resources #2783

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 25, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Oct 25, 2024
@yfodil yfodil self-assigned this Oct 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 76.56250% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (fe86049) to head (ab0f826).
Report is 209 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/ipam/ip.go 72.72% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2783      +/-   ##
==========================================
- Coverage   71.43%   67.48%   -3.95%     
==========================================
  Files         277      328      +51     
  Lines       35875    38800    +2925     
==========================================
+ Hits        25628    26186     +558     
- Misses       8028    10366    +2338     
- Partials     2219     2248      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil marked this pull request as ready for review October 25, 2024 08:11
@yfodil yfodil requested a review from remyleone as a code owner October 25, 2024 08:12
fenollp
fenollp previously approved these changes Oct 25, 2024
@remyleone remyleone added this pull request to the merge queue Oct 28, 2024
Merged via the queue into scaleway:master with commit 7cfabed Oct 28, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants