Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object): migration from aws-sdk-go to aws-sdk-go-v2 #2798

Merged
merged 34 commits into from
Dec 5, 2024

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Nov 7, 2024

No description provided.

@Laure-di Laure-di marked this pull request as draft November 7, 2024 16:31
@github-actions github-actions bot added the object Object storage issues, bugs and feature requests label Nov 7, 2024
@Laure-di Laure-di changed the title change to sdk-go-aws-v2 fix(object): migration from sdk-go-aws to sdk-go-aws-v2 Dec 4, 2024
@Laure-di Laure-di changed the title fix(object): migration from sdk-go-aws to sdk-go-aws-v2 fix(object): migration from aws-sdk-go to aws-sdk-go-v2 Dec 4, 2024
@github-actions github-actions bot added the load-balancer Load-balancer issues, bugs and feature requests label Dec 4, 2024
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Dec 4, 2024
@Laure-di Laure-di self-assigned this Dec 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 79.83015% with 95 lines in your changes missing coverage. Please review.

Project coverage is 67.70%. Comparing base (fe86049) to head (c6ceefe).
Report is 238 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/object/helpers_object.go 67.37% 48 Missing and 13 partials ⚠️
internal/services/object/bucket.go 82.45% 15 Missing and 5 partials ⚠️
...al/services/object/bucket_website_configuration.go 84.61% 2 Missing and 2 partials ⚠️
internal/services/object/bucket_policy.go 75.00% 1 Missing and 2 partials ⚠️
internal/services/object/bucket_acl.go 96.07% 0 Missing and 2 partials ⚠️
...ernal/services/object/bucket_lock_configuration.go 93.33% 0 Missing and 2 partials ⚠️
internal/services/object/clients.go 0.00% 2 Missing ⚠️
...ervices/object/data_source_object_bucket_policy.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
- Coverage   71.43%   67.70%   -3.74%     
==========================================
  Files         277      339      +62     
  Lines       35875    40090    +4215     
==========================================
+ Hits        25628    27143    +1515     
- Misses       8028    10637    +2609     
- Partials     2219     2310      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di marked this pull request as ready for review December 5, 2024 09:44
remyleone
remyleone previously approved these changes Dec 5, 2024
@remyleone remyleone added this pull request to the merge queue Dec 5, 2024
Merged via the queue into scaleway:master with commit 494bc9e Dec 5, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests object Object storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants