Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance_server): use sbs api per default for block volumes #2804

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Nov 13, 2024

No description provided.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Nov 13, 2024
@Codelax Codelax requested a review from yfodil as a code owner November 13, 2024 10:18
@github-actions github-actions bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (fe86049) to head (849a06f).
Report is 223 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/instance/server.go 78.94% 3 Missing and 1 partial ⚠️
...ternal/services/instance/helpers_instance_block.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
- Coverage   71.43%   67.65%   -3.78%     
==========================================
  Files         277      339      +62     
  Lines       35875    39924    +4049     
==========================================
+ Hits        25628    27012    +1384     
- Misses       8028    10598    +2570     
- Partials     2219     2314      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as draft November 13, 2024 10:49
@Codelax Codelax self-assigned this Nov 13, 2024
@Codelax Codelax marked this pull request as ready for review November 13, 2024 12:49
@remyleone remyleone added this pull request to the merge queue Nov 13, 2024
Merged via the queue into scaleway:master with commit 698763e Nov 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants