Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baremetal): custom partitionning #2820

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Nov 27, 2024

close #2817

@Laure-di Laure-di marked this pull request as draft November 27, 2024 14:35
@Laure-di Laure-di force-pushed the baremetal-partition branch from 9564c15 to c199ba7 Compare November 27, 2024 14:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (fe86049) to head (517d7aa).
Report is 235 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/baremetal/server.go 82.14% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
- Coverage   71.43%   67.69%   -3.75%     
==========================================
  Files         277      339      +62     
  Lines       35875    40016    +4141     
==========================================
+ Hits        25628    27089    +1461     
- Misses       8028    10611    +2583     
- Partials     2219     2316      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the baremetal-partition branch from 6d4c461 to 5520695 Compare December 3, 2024 07:08
@github-actions github-actions bot added the flexible-ip Flexible IP issues, bugs and feature requests label Dec 3, 2024
@Laure-di Laure-di force-pushed the baremetal-partition branch from 0c8bf5f to c298749 Compare December 3, 2024 09:38
@Laure-di Laure-di marked this pull request as ready for review December 3, 2024 09:42
@Laure-di Laure-di requested a review from yfodil as a code owner December 3, 2024 09:42
Codelax
Codelax previously approved these changes Dec 3, 2024
@Codelax Codelax added this pull request to the merge queue Dec 5, 2024
Merged via the queue into scaleway:master with commit 33cad2e Dec 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baremetal flexible-ip Flexible IP issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(baremetal): add support for custom disk partitioning
3 participants