Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance_image): support block snapshots #2823

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Nov 29, 2024

Close #2819

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 53.08642% with 38 lines in your changes missing coverage. Please review.

Project coverage is 67.65%. Comparing base (fe86049) to head (ce84475).
Report is 235 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/services/instance/helpers_instance_block.go 0.00% 34 Missing ⚠️
internal/services/instance/server.go 72.72% 2 Missing and 1 partial ⚠️
internal/services/instance/types.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2823      +/-   ##
==========================================
- Coverage   71.43%   67.65%   -3.79%     
==========================================
  Files         277      339      +62     
  Lines       35875    40036    +4161     
==========================================
+ Hits        25628    27087    +1459     
- Misses       8028    10637    +2609     
- Partials     2219     2312      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the fix/instance-image-block-snapshots branch from 222aa17 to b85063d Compare December 3, 2024 10:03
@Codelax Codelax marked this pull request as ready for review December 3, 2024 10:10
@Codelax Codelax requested a review from remyleone as a code owner December 3, 2024 10:10
@Codelax Codelax force-pushed the fix/instance-image-block-snapshots branch from be71273 to f1a579d Compare December 3, 2024 13:27
split block volumes creations in two steps. Forcing order also force IDs with cassettes
@remyleone remyleone enabled auto-merge December 4, 2024 09:43
@remyleone remyleone added this pull request to the merge queue Dec 4, 2024
Merged via the queue into scaleway:master with commit e712a91 Dec 4, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support block snapshot in instance image
3 participants