Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object): add support encryption sse-c #2845

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Dec 10, 2024

close #2816

@Laure-di Laure-di requested a review from Mia-Cross as a code owner December 10, 2024 15:06
@github-actions github-actions bot added the object Object storage issues, bugs and feature requests label Dec 10, 2024
@Laure-di Laure-di force-pushed the encryption-object-sse-c branch from f7d5314 to 63de077 Compare December 10, 2024 15:06
@Laure-di Laure-di requested a review from Codelax as a code owner December 10, 2024 16:29
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 67.92453% with 17 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (fe86049) to head (637d206).
Report is 246 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/object/object.go 67.92% 13 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2845      +/-   ##
==========================================
- Coverage   71.43%   67.75%   -3.69%     
==========================================
  Files         277      339      +62     
  Lines       35875    40155    +4280     
==========================================
+ Hits        25628    27207    +1579     
- Misses       8028    10631    +2603     
- Partials     2219     2317      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the encryption-object-sse-c branch from 7d8864e to 637d206 Compare December 12, 2024 10:39
@remyleone remyleone enabled auto-merge December 12, 2024 10:42
@remyleone remyleone added this pull request to the merge queue Dec 12, 2024
Merged via the queue into scaleway:master with commit 9ed09eb Dec 12, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests object Object storage issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Server Side Encryption using SDK v2
3 participants