Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance_server): delete_after_termination for sbs volumes #2854

Merged
merged 5 commits into from
Dec 19, 2024
Merged

fix(instance_server): delete_after_termination for sbs volumes #2854

merged 5 commits into from
Dec 19, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 16, 2024

Fix #2853

@Codelax Codelax added bug instance Instance issues, bugs and feature requests sbs Scaleway Block Storage issues, bugs and feature requests labels Dec 16, 2024
@Codelax Codelax requested a review from yfodil as a code owner December 16, 2024 16:29
@github-actions github-actions bot added load-balancer Load-balancer issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw labels Dec 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.07692% with 37 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (fe86049) to head (540929b).
Report is 250 commits behind head on master.

Files with missing lines Patch % Lines
internal/services/instance/testfuncs/checks.go 0.00% 30 Missing ⚠️
internal/services/block/volume.go 0.00% 4 Missing ⚠️
...ternal/services/instance/helpers_instance_block.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2854      +/-   ##
==========================================
- Coverage   71.43%   67.71%   -3.73%     
==========================================
  Files         277      339      +62     
  Lines       35875    40258    +4383     
==========================================
+ Hits        25628    27260    +1632     
- Misses       8028    10679    +2651     
- Partials     2219     2319     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Dec 19, 2024
Merged via the queue into scaleway:master with commit 5d65352 Dec 19, 2024
41 checks passed
jremy42 pushed a commit that referenced this pull request Jan 30, 2025
@Codelax @jremy42
fix(instance_server): delete_after_termination for sbs volumes (#2854)
80279cd 
* fix(instance_server): delete_after_termination for sbs volumes

* fix: consider block volume deleted on 404

* update cassettes

* update TestAccSnapshot_Unified cassette

* update linked products cassettes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@yfodil yfodil Awaiting requested review from yfodil

Assignees
No one assigned
Labels
bug instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests sbs Scaleway Block Storage issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instance: Not Deleting SBS Volumes on Terraform Destroy
3 participants
@Codelax @codecov-commenter @remyleone