fix(object): change user-agent #2919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
object
Laure-di
force-pushed
the
custom-roundtripper-s3
branch
from
ef300d6 to
a121680
Compare
remyleone
reviewed
Feb 10, 2025
Laure-di
force-pushed
the
custom-roundtripper-s3
branch
2 times, most recently
from
8ea7005 to
3932d36
Compare
Laure-di
force-pushed
the
custom-roundtripper-s3
branch
from
a98c8ee to
d03de87
Compare
remyleone
reviewed
Feb 14, 2025
| @@ -37,6 +37,8 @@ const ( | |||
| maxObjectVersionDeletionWorkers = 8 | |||
|
|
|||
| ErrCodeForbidden = "Forbidden" | |||
|
|
|||
| defaultVersion = "v2.49.0" | |||
There was a problem hiding this comment.
how will this string get maintained through time?
| userAgent string | ||
| } | ||
|
|
||
| var userAgent = fmt.Sprintf("scaleway-terraform-provider/%s (%s; %s; %s)", defaultVersion, runtime.Version(), runtime.GOOS, runtime.GOARCH) |
There was a problem hiding this comment.
Suggested change
| var userAgent = fmt.Sprintf("scaleway-terraform-provider/%s (%s; %s; %s)", defaultVersion, runtime.Version(), runtime.GOOS, runtime.GOARCH) | |
| var userAgent = fmt.Sprintf("terraform-provider/%s (%s; %s; %s)", defaultVersion, runtime.Version(), runtime.GOOS, runtime.GOARCH) |
There was a problem hiding this comment.
You could also add the version of terraform as well.
here is an example of what we currently have:
scaleway-sdk-go/v1.0.0-beta.30.0.20241129094524-023aa8142bc1 (go1.23.1; linux; amd64) terraform-provider/2.49.0 terraform/1.10.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.