Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rdb): add scaleway_rdb_user_resource_beta #520

Merged
merged 20 commits into from
Sep 11, 2020
Merged

feat(rdb): add scaleway_rdb_user_resource_beta #520

merged 20 commits into from
Sep 11, 2020

Conversation

paulez
Copy link
Contributor

@paulez paulez commented Jul 9, 2020

This is to add a resource to manage RDB database users.

This allows to manage users admin permissions and passwords on RDB instances.

I've run the acceptance tests I've added:

17:12 paul@sca1 ~/github/terraform-provider-scaleway/scaleway% time TF_ACC=1 go test -v . -run "TestAccScalewayRdbUser*" -timeout=10m -count=1
=== RUN   TestAccScalewayRdbUserBeta
=== PAUSE TestAccScalewayRdbUserBeta
=== CONT  TestAccScalewayRdbUserBeta
--- PASS: TestAccScalewayRdbUserBeta (214.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-scaleway/scaleway	214.609s
TF_ACC=1 go test -v . -run "TestAccScalewayRdbUser*" -timeout=10m -count=1  6,05s user 0,81s system 3% cpu 3:37,17 total

Next step will be to allow creating instances without setting a user and password, so users can be fully managed using this type of resource.

@paulez paulez mentioned this pull request Jul 22, 2020
Merged
kindermoumoute
kindermoumoute requested changes Sep 8, 2020
View reviewed changes
kindermoumoute
kindermoumoute approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kindermoumoute kindermoumoute changed the title Add scaleway_rdb_user_resource_beta feat(rdb): add scaleway_rdb_user_resource_beta Sep 11, 2020
@kindermoumoute kindermoumoute merged commit ab01135 into scaleway:master Sep 11, 2020
@remyleone remyleone added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
documentation rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulez @remyleone @kindermoumoute