Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): use goreleaser #530

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

kindermoumoute
Copy link
Contributor

@kindermoumoute kindermoumoute commented Aug 20, 2020

Notes:

  • Secrets GPG_PRIVATE_KEY, PASSPHRASE and GITHUB_TOKEN must be set
  • Changelog does not use conventional commit (this is not a feature of goreleaser)
  • Version is set through a ldflag github.com/scaleway/terraform-provider-scaleway/scaleway.version={{.Version}}, either we choose not to commit version anymore, either we add some kind of post-release workflow that open a PR

@remyleone
Copy link
Member

Should we use a script similar to the one in https://github.com/scaleway/scaleway-cli to have the environment variables set the credentials available?

@kindermoumoute
Copy link
Contributor Author

Should we use a script similar to the one in https://github.com/scaleway/scaleway-cli to have the environment variables set the credentials available?

There are too many difference between a CLI release and a terraform plugin release to use the same script ultimately:

  • Terraform GPG keys process
  • CLI release container, distribution-specific package, ...

@kindermoumoute kindermoumoute merged commit f2cb1ea into scaleway:master Sep 18, 2020
@kindermoumoute kindermoumoute deleted the release-script branch September 18, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants