Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(account): add support for project in SSH key #603

Merged
merged 3 commits into from
Oct 14, 2020
Merged

feat(account): add support for project in SSH key #603

merged 3 commits into from
Oct 14, 2020

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone linked an issue Oct 6, 2020 that may be closed by this pull request
Add project_id in scaleway_account_ssh_key resource #535
Closed
4 tasks
QuentinBrosse
QuentinBrosse suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for the project_id field.

Sh4d1
Sh4d1 previously approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, we don't have acc tests with a custom organization, so no new tests are needed.

@remyleone remyleone merged commit 21d3fb5 into scaleway:master Oct 14, 2020
@remyleone remyleone deleted the project_account branch October 14, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@Sh4d1 Sh4d1 Sh4d1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project_id in scaleway_account_ssh_key resource
3 participants
@remyleone @Sh4d1 @QuentinBrosse