Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registry): add support for project in namespace #607

Merged
merged 5 commits into from
Dec 9, 2020
Merged

feat(registry): add support for project in namespace #607

merged 5 commits into from
Dec 9, 2020

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone linked an issue Oct 7, 2020 that may be closed by this pull request
Add project_id in all registry resources and data sources #541
Closed
2 tasks
Sh4d1
Sh4d1 suggested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait, it's not deployed yet

jerome-quere
jerome-quere previously approved these changes Oct 7, 2020
View reviewed changes
@remyleone remyleone mentioned this pull request Oct 19, 2020
Closed
@remyleone remyleone marked this pull request as draft October 20, 2020 09:37
@remyleone remyleone marked this pull request as ready for review December 9, 2020 09:35
QuentinBrosse
QuentinBrosse previously approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sh4d1
Sh4d1 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@Sh4d1 Sh4d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit f31543e into scaleway:master Dec 9, 2020
@remyleone remyleone deleted the project_registry branch December 9, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh4d1 Sh4d1 Sh4d1 approved these changes

@jerome-quere jerome-quere jerome-quere left review comments

@QuentinBrosse QuentinBrosse QuentinBrosse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add project_id in all registry resources and data sources
4 participants
@remyleone @jerome-quere @Sh4d1 @QuentinBrosse