Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account): fix conflict when renaming a resource #714

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft November 23, 2020 16:18
@remyleone
Copy link
Member Author

Blocked by internal ticket AUTH-392

@kindermoumoute
Copy link
Contributor

I suggest we close this PR since this behavior is on the SSH key API side. (we can reopen it the day we change the API)

@remyleone remyleone marked this pull request as ready for review April 15, 2022 13:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #714 (aae625c) into master (f167df6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #714   +/-   ##
======================================
  Coverage    1.51%   1.51%           
======================================
  Files          95      95           
  Lines       15486   15486           
======================================
  Hits          235     235           
  Misses      15228   15228           
  Partials       23      23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f167df6...aae625c. Read the comment docs.

@remyleone remyleone merged commit e511cf1 into scaleway:master Apr 15, 2022
@remyleone remyleone deleted the conflict_ssh branch April 15, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

​An error occurs if the ssh key needs to be destroyed and then created
4 participants