Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): brk change, use TypeMap for user_data and remove user… #738

Merged
merged 8 commits into from
Jan 13, 2021
Merged

feat(instance): brk change, use TypeMap for user_data and remove user… #738

merged 8 commits into from
Jan 13, 2021

Conversation

remyleone
Copy link
Member

…_data

@remyleone remyleone linked an issue Jan 7, 2021 that may be closed by this pull request
Server UserData should be a list not a Set #704
Closed
kindermoumoute
kindermoumoute approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit c89b594 into scaleway:master Jan 13, 2021
@remyleone remyleone deleted the user_data branch January 13, 2021 10:12
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server UserData should be a list not a Set
2 participants
@remyleone @kindermoumoute