Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: brk make organization_id computed #746

Merged
merged 19 commits into from
Jan 12, 2021
Merged

feat: brk make organization_id computed #746

merged 19 commits into from
Jan 12, 2021

Conversation

remyleone
Copy link
Member

No description provided.

kindermoumoute
kindermoumoute requested changes Jan 8, 2021
View reviewed changes
remyleone and others added 17 commits January 12, 2021 14:07
@remyleone @kindermoumoute
Update docs/data-sources/registry_namespace.md
1df5784 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/k8s_cluster.md
03d70d8 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/baremetal_server.md
60f350d 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/account_ssh_key.md
772b282 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/index.md
8ca94b8 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/lb.md
8542763 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/instance_ip.md
b9c2414 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/rdb_instance.md
8c63222 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/vpc_private_network.md
8787c31 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/registry_namespace.md
7f5f271 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/data-sources/registry_image.md
76fd1aa 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/instance_placement_group.md
c2c18eb 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/instance_security_group.md
c38b921 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/instance_server.md
d9100c6 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone @kindermoumoute
Update docs/resources/instance_volume.md
b553e0f 
Co-authored-by: Olivier Cano <[email protected]>
@remyleone
Merge branch 'master' into organization_computed
75db9e2
@remyleone
Fix
119a1b9
kindermoumoute
kindermoumoute approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remyleone remyleone merged commit 3fe3e5c into scaleway:master Jan 12, 2021
@remyleone remyleone deleted the organization_computed branch January 12, 2021 14:01
@remyleone remyleone mentioned this pull request Jan 13, 2021
Closed
@remyleone remyleone linked an issue Jan 13, 2021 that may be closed by this pull request
make organization id computed and project id optional #744
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBrosse QuentinBrosse QuentinBrosse left review comments

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make organization id computed and project id optional
3 participants
@remyleone @kindermoumoute @QuentinBrosse