Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instance): Fix block volume detach when no additional volumes remaining #789

Merged
merged 10 commits into from
Jun 3, 2022
Merged

fix(instance): Fix block volume detach when no additional volumes remaining #789

merged 10 commits into from
Jun 3, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone marked this pull request as draft February 26, 2021 15:20
@remyleone remyleone added bug instance Instance issues, bugs and feature requests labels Feb 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #789 (e8fc14b) into master (9afb4ca) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master     #789   +/-   ##
=======================================
  Coverage   69.88%   69.89%           
=======================================
  Files         102      102           
  Lines       16332    16337    +5     
=======================================
+ Hits        11414    11419    +5     
  Misses       3934     3934           
  Partials      984      984
Impacted Files Coverage Δ
scaleway/resource_instance_volume.go 73.77% <85.71%> (+0.23%) ⬆️
scaleway/resource_instance_server.go 72.71% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afb4ca...e8fc14b. Read the comment docs.

@Codelax Codelax marked this pull request as ready for review June 2, 2022 13:21
@Codelax Codelax changed the title fix(instance): Fix inconsistant block volume detach fix(instance): Fix block volume detach when no additional volumes remaining Jun 2, 2022
@remyleone remyleone merged commit 53cb4ff into scaleway:master Jun 3, 2022
@remyleone remyleone deleted the block_non_empty branch June 3, 2022 13:51
remyleone added a commit to remyleone/terraform-provider-scaleway that referenced this pull request Jun 17, 2022
@remyleone @Codelax
fix(instance): Fix block volume detach when no additional volumes rem…
47dda75 
…aining (scaleway#789)

Co-authored-by: Jules Casteran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monitob Monitob Monitob approved these changes

Assignees
No one assigned
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remyleone @codecov-commenter @Monitob @Codelax