Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance/volume): Wait for the volume after resizing it #836

Merged
merged 5 commits into from
May 19, 2021

Conversation

jeansebastienh
Copy link
Contributor

@jeansebastienh jeansebastienh commented May 17, 2021

The test was failing although the volume was properly resized.

The provider was waiting before resizing the volume.

--- PASS: TestAccScalewayInstanceVolume_ResizeBlock (18.26s)                                                           
PASS                                                                                                                   
ok      github.com/scaleway/terraform-provider-scaleway/scaleway        18.271s  

@jeansebastienh jeansebastienh requested a review from remyleone May 19, 2021 14:44
@remyleone remyleone merged commit c4c6547 into scaleway:master May 19, 2021
@jeansebastienh jeansebastienh deleted the fix-resize-block branch May 21, 2021 08:40
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants