Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baremetal): add support for os data source #857

Merged
merged 6 commits into from
Apr 15, 2022

Conversation

remyleone
Copy link
Member

No description provided.

@remyleone remyleone linked an issue Jul 12, 2021 that may be closed by this pull request
2 tasks
@remyleone remyleone marked this pull request as draft March 28, 2022 13:12
@remyleone remyleone marked this pull request as ready for review April 15, 2022 12:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #857 (03a7b79) into master (e511cf1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #857      +/-   ##
=========================================
- Coverage    1.51%   1.51%   -0.01%     
=========================================
  Files          95      96       +1     
  Lines       15486   15558      +72     
=========================================
  Hits          235     235              
- Misses      15228   15300      +72     
  Partials       23      23              
Impacted Files Coverage Δ
scaleway/data_source_baremetal_os.go 0.00% <0.00%> (ø)
scaleway/provider.go 18.06% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e511cf1...03a7b79. Read the comment docs.

@Monitob
Copy link
Contributor

Monitob commented Apr 15, 2022

@remyleone Looks great the PR can you add the doc please.

@remyleone remyleone merged commit be51284 into scaleway:master Apr 15, 2022
@remyleone remyleone deleted the baremetal_os_data branch April 15, 2022 14:05
@remyleone remyleone added the elastic-metal Elastic-metal issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elastic-metal Elastic-metal issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add data source support for baremetal ressources
3 participants