feat(lb): add support for private network in lb resource #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Monitob
commented
Nov 3, 2021
Monitob
commented
- Support private network on a load balancer
remyleone
changed the title
remyleone
reviewed
Nov 8, 2021
remyleone
reviewed
Nov 8, 2021
Co-authored-by: Rémy Léone <[email protected]>
remyleone
reviewed
Nov 10, 2021
remyleone
reviewed
Nov 15, 2021
remyleone
approved these changes
Nov 15, 2021
Monitob
added a commit
to Monitob/terraform-provider-scaleway
that referenced
this pull request
Nov 16, 2021
* feat(lb-pn): add private network to lb * feat(lb-pn): remote lb private network * feat(lb-pn): add static_config test * feat(lb-pn): update all lb cassettes * feat(lb-pn): update all lb cassettes * feat(lb-pn): set zone schema * Update scaleway/resource_lb.go Co-authored-by: Rémy Léone <[email protected]> * feat(lb-pn): add wait private network state, update for private networks, test update * feat(lb-pn): add wait private network state, update for private networks, test update * feat(lb): update selector * feat(lb-pn): remove trailing number * feat(lb-pn): simplify static config check helper Co-authored-by: Rémy Léone <[email protected]>
remyleone
added a commit
to remyleone/terraform-provider-scaleway
that referenced
this pull request
Mar 28, 2022
* feat(lb-pn): add private network to lb * feat(lb-pn): remote lb private network * feat(lb-pn): add static_config test * feat(lb-pn): update all lb cassettes * feat(lb-pn): update all lb cassettes * feat(lb-pn): set zone schema * Update scaleway/resource_lb.go Co-authored-by: Rémy Léone <[email protected]> * feat(lb-pn): add wait private network state, update for private networks, test update * feat(lb-pn): add wait private network state, update for private networks, test update * feat(lb): update selector * feat(lb-pn): remove trailing number * feat(lb-pn): simplify static config check helper Co-authored-by: Rémy Léone <[email protected]>
remyleone
added
the
load-balancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.