Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): return error code from k8sGetLatestVersionFromMinor call #984

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

detached
Copy link
Contributor

The k8sGetLatestVersionFromMinor call is the first interaction with the scaleway API when auto_update is enabled and the version is set to a x.y minor version.
But a possible error message from the API call is never logged. So if you have a typo in your credentials or forgot to add the project_id to the provider, you are confronted with the error message "minor version x.y must be used with auto upgrade enable".

This PR just reports the error from k8sGetLatestVersionFromMinor to the user.

@detached detached changed the title [WIP] Don't hide error from k8sGetLatestVersionFromMinor call Don't hide error from k8sGetLatestVersionFromMinor call Dec 30, 2021
@remyleone remyleone changed the title Don't hide error from k8sGetLatestVersionFromMinor call fix(k8s): return error code from k8sGetLatestVersionFromMinor call Dec 30, 2021
@remyleone remyleone merged commit a9fc5a9 into scaleway:master Dec 30, 2021
@remyleone
Copy link
Member

Thanks a lot :)

@detached detached deleted the dont-hide-api-error branch January 7, 2022 07:54
remyleone pushed a commit to remyleone/terraform-provider-scaleway that referenced this pull request Mar 28, 2022
@remyleone remyleone added the k8s Kubernetes Kapsule issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s Kubernetes Kapsule issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants