Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop calling deprecated method #212

Closed
wants to merge 1 commit into from
Closed

Conversation

sylwit
Copy link

@sylwit sylwit commented Feb 7, 2018

To get rid of this warning:

UserWarning: IPASN._parse_fields_dns() has been deprecated and will be removed. You should now use IPASN.parse_fields_dns().

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 99.932% when pulling 75def04 on sylwit:patch-1 into ad6cbc6 on secynic:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 7, 2018

Coverage Status

Coverage decreased (-0.07%) to 99.932% when pulling 75def04 on sylwit:patch-1 into ad6cbc6 on secynic:master.

@sylwit
Copy link
Author

sylwit commented Feb 7, 2018

and tests are not mocked ?
ipwhois.experimental: DEBUG: ASN bulk query socket error: [Errno 110] Connection timed out

@pmuller
Copy link

pmuller commented Feb 21, 2018

_parse_fields_dns is not the only deprecated method called by lookup(). You should replace calls toward _parse_fields_*().

@secynic
Copy link
Owner

secynic commented Feb 23, 2018

@sylwit There are offline (mocked) tests, and online. Online tests are also enabled on Travis due to the inconsistency in the various RIR services (it helps catch issues last minute, without re-running the tests locally).

I can't accept this PR for a couple reasons:

Check out my response on #203 for a temporary workaround.

@secynic secynic closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants