Gemma2 reward model support #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqweteddy
requested review from
merrymercy,
Ying1123,
hnyls2002,
zhyncs,
ispobock and
ByronHsu
as code owners
merrymercy
reviewed
Nov 8, 2024
Comment on lines
+60
to
+63
| hidden_states = self.model(input_ids, positions, forward_batch, input_embeds) | ||
| scores = self.score(hidden_states) | ||
|
|
||
| return self.pooler(scores, forward_batch) |
There was a problem hiding this comment.
There is an optimization opportunity here. You can run self.pooler first and then run self.score. This can skip matmul for some dimensions and make it run faster. Can you try this in a follow-up PR?
There was a problem hiding this comment.
I've opened a new PR #1956.
leishaoSC
added a commit
to leishaoSC/sglang
that referenced
this pull request
Nov 8, 2024
Gemma2 reward model support (sgl-project#1954)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Gemma2 reward model, such as Skywork/Skywork-Reward-Gemma-2-27B-v0.2.
Modifications
gemma2_reward.pyinpython/sglang/srt/models.docs/references/supported_models.md.Checklist