Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split code into multiple packages #234

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jan 4, 2024

Minor cleanup, and code split into multiple packages to simplify development

Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5ee376f) 53.34% compared to head (b113b73) 53.34%.

Files Patch % Lines
cmd/argo-watcher/server/server.go 0.00% 6 Missing ⚠️
cmd/argo-watcher/argocd/argo.go 57.14% 3 Missing ⚠️
cmd/argo-watcher/argocd/argo_status_updater.go 75.00% 0 Missing and 1 partial ⚠️
cmd/argo-watcher/main.go 0.00% 1 Missing ⚠️
cmd/argo-watcher/server/router.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files          18       18           
  Lines        1331     1331           
=======================================
  Hits          710      710           
  Misses        556      556           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i changed the title chore: minor refactoring chore: split code into multiple packages Jan 4, 2024
@shini4i shini4i merged commit 17769f7 into main Jan 4, 2024
@shini4i shini4i deleted the chore/small-refactoring branch January 4, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant