Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify waitForApplicationDeployment #250

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Feb 5, 2024

No description provided.

Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (1dcf34a) 53.51% compared to head (374c697) 53.42%.
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/argo-watcher/argocd/argo_status_updater.go 35.13% 23 Missing and 1 partial ⚠️
cmd/argo-watcher/server/server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   53.51%   53.42%   -0.10%     
==========================================
  Files          20       20              
  Lines        1379     1402      +23     
==========================================
+ Hits          738      749      +11     
- Misses        576      586      +10     
- Partials       65       67       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i merged commit 78e6d1b into main Feb 5, 2024
2 of 4 checks passed
@shini4i shini4i deleted the chore/small-argo-status-updater-refactor branch February 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant