Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lockdown improvements #279

Merged
merged 13 commits into from
Apr 22, 2024
Merged

chore: lockdown improvements #279

merged 13 commits into from
Apr 22, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Apr 19, 2024

Closes #273

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 64.61538% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 52.90%. Comparing base (bd78471) to head (555cd9c).
Report is 1 commits behind head on main.

❗ Current head 555cd9c differs from pull request most recent head 0d6b804. Consider uploading reports for the commit 0d6b804 to get more accurate results

Files Patch % Lines
cmd/argo-watcher/server/lockdown.go 65.85% 32 Missing and 10 partials ⚠️
cmd/argo-watcher/server/server.go 0.00% 3 Missing ⚠️
cmd/argo-watcher/server/router.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   51.74%   52.90%   +1.15%     
==========================================
  Files          26       25       -1     
  Lines        1720     1809      +89     
==========================================
+ Hits          890      957      +67     
- Misses        751      764      +13     
- Partials       79       88       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit f601fc4 into main Apr 22, 2024
3 checks passed
@shini4i shini4i deleted the chore/lockdown-improvements branch April 22, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve deployment lock logic
1 participant