Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updater): commit message template #281

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Conversation

tomsozolins
Copy link
Collaborator

closes #276

@tomsozolins tomsozolins requested a review from shini4i April 30, 2024 13:43
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 53.42%. Comparing base (f601fc4) to head (79af9fa).

Files Patch % Lines
pkg/updater/updater.go 60.52% 13 Missing and 2 partials ⚠️
pkg/updater/config.go 57.14% 2 Missing and 1 partial ⚠️
internal/models/argo.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   52.90%   53.42%   +0.52%     
==========================================
  Files          25       26       +1     
  Lines        1809     1840      +31     
==========================================
+ Hits          957      983      +26     
- Misses        764      766       +2     
- Partials       88       91       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@shini4i shini4i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shini4i shini4i merged commit f0187e9 into main Apr 30, 2024
5 checks passed
@shini4i shini4i deleted the feat/commit-message-template branch April 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for providing commit message template
2 participants