Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for providing task timeout from client #287

Merged
merged 1 commit into from
May 2, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented May 1, 2024

No description provided.

Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.37%. Comparing base (b787e81) to head (1746436).

Files Patch % Lines
cmd/argo-watcher/argocd/argo_status_updater.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   53.41%   53.37%   -0.05%     
==========================================
  Files          26       26              
  Lines        1831     1838       +7     
==========================================
+ Hits          978      981       +3     
- Misses        762      765       +3     
- Partials       91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i merged commit 0ab5109 into main May 2, 2024
3 of 5 checks passed
@shini4i shini4i deleted the chore/task-timeout-override branch May 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant