Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): reduce cognitive complexity in lockdown implementation #294

Merged
merged 2 commits into from
May 7, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented May 5, 2024

No description provided.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 53.45%. Comparing base (452b9a2) to head (b1b5811).

Files Patch % Lines
cmd/argo-watcher/server/lockdown.go 64.70% 12 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   53.27%   53.45%   +0.17%     
==========================================
  Files          26       26              
  Lines        1815     1822       +7     
==========================================
+ Hits          967      974       +7     
  Misses        757      757              
  Partials       91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i marked this pull request as ready for review May 7, 2024 19:02
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit af2cb29 into main May 7, 2024
5 checks passed
@shini4i shini4i deleted the chore/fix-code-smell-lockdown branch May 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant