Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JWT support #299

Merged
merged 19 commits into from
May 15, 2024
Merged

feat: add JWT support #299

merged 19 commits into from
May 15, 2024

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented May 12, 2024

This PR adds support for JWT as an upcoming replacement for the deploy token. It's the first step for achieving the goal stated in #288.

Currently, we support both old deploy token and JWT for adding new tasks.

@shini4i shini4i changed the title feat(backend): prep for jwt integration feat: add jwt support May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 37.67123% with 91 lines in your changes are missing coverage. Please review.

Project coverage is 54.44%. Comparing base (318358a) to head (a4c0d27).

❗ Current head a4c0d27 differs from pull request most recent head 23fc008. Consider uploading reports for the commit 23fc008 to get more accurate results

Files Patch % Lines
cmd/argo-watcher/server/router.go 24.71% 64 Missing and 3 partials ⚠️
pkg/client/client.go 6.25% 14 Missing and 1 partial ⚠️
cmd/argo-watcher/auth/jwt.go 60.00% 4 Missing and 2 partials ⚠️
cmd/argo-watcher/server/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   53.90%   54.44%   +0.54%     
==========================================
  Files          26       28       +2     
  Lines        1829     1899      +70     
==========================================
+ Hits          986     1034      +48     
- Misses        752      773      +21     
- Partials       91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i changed the title feat: add jwt support feat: add JWT support May 14, 2024
@shini4i shini4i marked this pull request as ready for review May 14, 2024 18:35
@shini4i shini4i requested a review from bozerkins May 14, 2024 18:36
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shini4i shini4i merged commit 37a1e33 into main May 15, 2024
2 of 3 checks passed
@shini4i shini4i deleted the feat/jwt branch May 15, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant