Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updater): add fire and forget mode #309

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Jun 10, 2024

Closes #308 by implementing argo-watcher/fire-and-forget annotation.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (71044ba) to head (7163da3).

Files Patch % Lines
cmd/argo-watcher/argocd/argo_status_updater.go 0.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   56.19%   56.10%   -0.10%     
==========================================
  Files          27       27              
  Lines        1847     1859      +12     
==========================================
+ Hits         1038     1043       +5     
- Misses        717      722       +5     
- Partials       92       94       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shini4i shini4i merged commit 0350ee7 into main Jun 10, 2024
7 of 9 checks passed
@shini4i shini4i deleted the chore/add-fire-and-forget branch June 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment fail in specific case
1 participant