dir-glob Dependency issue

[TomVance]

Hi guys just a heads up,

It looks like there is an issue with the dir-glob module which according to npm was bumped to version 2.2.0 earlier today. The package.json for this project requires it with a hat (https://github.com/sindresorhus/globby/blob/master/package.json#L59).

Looking at this project on github however it's not been updated since February 2018: https://github.com/kevva/dir-glob which looks a little suspicious.

Our builds where receiving the following error:

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined

:)

[hashar]

Ditto and after some digging globby v0.8.1 ( https://github.com/sindresorhus/globby/blob/v8.0.1/package.json ) has:

{
    "dependencies": {
        "dir-glob": "^2.0.0",
    }
}

Which previously matched 2.0.0 and now matches 2.2.0.

Filled one for dir-glob in case they broke their package: kevva/dir-glob#10

Most probably globby should have a more strict version requirement for dir-glob :)

Our bug https://phabricator.wikimedia.org/T213249

[sindresorhus]

Fixed in [email protected]

https://github.com/sindresorhus/globby/commits/v8-release

[mrtnbroder]

@sindresorhus the build failed though

[hashar]

8.0.2 is not yet on the npm registry https://www.npmjs.com/package/globby . But maybe it can be manually force refreshed.

[sindresorhus]

It shows there for me.

[sindresorhus]

@mrtnbroder That’s just because of some lint issues.

[hashar]

Works for us now. Thank you very much.

[marswong]

@sindresorhus it proves the necessity of package-lock.json, unless u maintain every node module :)

[kevva]

@marswong, npm doesnt use the package-lock.json in modules so it wouldn't catch this. If anything, it would prevent this issue from surfacing when testing locally.