Support cli var substitution in docker login command env #4871
+85
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2707.
This PR supports variable substitution
$(...)
in docker login envs includingSKYPILOT_DOCKER_USERNAME
,SKYPILOT_DOCKER_PASSWORD
andSKYPILOT_DOCKER_SERVER
. This is particularly useful when users need a dynamic pswd, like$(aws ecr get-login-password --region us-west-2)
.Tests:
I manually create a private image, and store my docker access token in
pswd.txt
, then:No idea why
Successfully executed command for Docker password
appears twice, seems like a known issue, is the DockerLoginConfig inited multiple times causingfrom_env_vars
executed multiple times? Executing user-provided commands not just once may have some issues here. Cc'ing @cblmemo