[API server] attach setup of controllers #4931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <[email protected]>
|
/smoke-test -k test_managed_jobs_basic |
Signed-off-by: Aylei <[email protected]>
|
/smoke-test -k test_managed_jobs_basic |
cg505
approved these changes
Mar 12, 2025
| @@ -529,6 +529,13 @@ def launch( | |||
| ] | |||
| skip_unnecessary_provisioning = True | |||
|
|
|||
| detach_setup = True | |||
| if controller_utils.Controllers.from_name(cluster_name) is not None: | |||
There was a problem hiding this comment.
nit: can we just do detach_setup = controller_utils.Controllers.from_name(cluster_name) is not None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4783
The total time of first
sky jobs launchis unchanged.This PR:
Master:
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orconda deactivate; bash -i tests/backward_compatibility_tests.sh(local)