Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Simplified buildkite agent queue #4932

Merged

Conversation

zpoint
Copy link
Collaborator

@zpoint zpoint commented Mar 12, 2025

Previously, we separated backend compact tests, service tests, and generic cloud tests into different Buildkite queues because multiple agents were running on the same instance and could interfere with each other, so we assigned them to different queues.

Now that they're containerized with Docker, we can reuse the same queue and maximize throughput.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or conda deactivate; bash -i tests/backward_compatibility_tests.sh (local)

@zpoint
Copy link
Collaborator Author

zpoint commented Mar 12, 2025

/quicktest-core

@zpoint zpoint changed the title [Test] Simplified buildkitea agent queue [Test] Simplified buildkite agent queue Mar 12, 2025
@zpoint zpoint requested a review from Michaelvll March 12, 2025 14:01
@Michaelvll Michaelvll requested a review from aylei March 13, 2025 03:18
Copy link
Collaborator

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zpoint !

@zpoint
Copy link
Collaborator Author

zpoint commented Mar 14, 2025

/quicktest-core

@zpoint
Copy link
Collaborator Author

zpoint commented Mar 14, 2025

/quicktest-core

@zpoint zpoint merged commit 84c6430 into skypilot-org:master Mar 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants