Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] SPECIFICATIONS google doc is private #2926

Closed
noqcks opened this issue Oct 29, 2023 · 4 comments · Fixed by #3004
Closed

[bug] SPECIFICATIONS google doc is private #2926

noqcks opened this issue Oct 29, 2023 · 4 comments · Fixed by #3004
Labels
type:bug Something isn't working type:documentation Improvements or additions to documentation

Comments

@noqcks
Copy link

noqcks commented Oct 29, 2023

Describe the bug

The google doc referenced for source level provenance on the SPECIFICATIONS page is private.

https://github.com/slsa-framework/slsa-github-generator/blob/main/SPECIFICATIONS.md#source-level-provenance

https://docs.google.com/document/d/10B-8R3NIGvcPuoIhqb-p18oOe78m6SiiukfE7NyvnYQ/preview

Expected behavior

Access to this document

@noqcks noqcks added status:triage Issue that has not been triaged type:bug Something isn't working labels Oct 29, 2023
@ianlewis ianlewis added type:documentation Improvements or additions to documentation and removed status:triage Issue that has not been triaged labels Nov 27, 2023
@ianlewis
Copy link
Member

@TomHennen This doc doesn't seem to be accessible publicly though you have marked it for public consumption. Could you take a look at the current access restrictions?

@laurentsimon Is it worth making a copy for this repo? Currently we don't support any kind of source attestations though so I'm not sure keeping this section in the SPECIFICATIONS doc is really worth it until we do.

@TomHennen
Copy link

@TomHennen This doc doesn't seem to be accessible publicly though you have marked it for public consumption. Could you take a look at the current access restrictions?

Hmm, it looks like I cannot share a doc from my work Google Docs completely publicly. It has previously been shared with https://groups.google.com/g/slsa-discussion/ (which anyone can join). When the doc was originally shared I think the instructions to join that group were noted with it, but they've gotten lost.

We can either 1) add the instructions back, or 2) I can make a copy with my personal Google Docs account and share that publicly. 3) Turn it into markdown and upload somewhere (where?).

Any thoughts?

@laurentsimon
Copy link
Collaborator

@laurentsimon Is it worth making a copy for this repo? Currently we don't support any kind of source attestations though so I'm not sure keeping this section in the SPECIFICATIONS doc is really worth it until we do.

Let's just remove the link and point folks to the tracking issue slsa-framework/slsa#956 if they want to know more. I'll send a PR

@laurentsimon
Copy link
Collaborator

See #3004

laurentsimon added a commit that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@ianlewis @noqcks @TomHennen @laurentsimon and others