Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve concurrency in the JavaView #828

Merged
merged 9 commits into from
Jan 25, 2024

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Jan 23, 2024

fix getting javaidentifierfactories from view
closes #827

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (17ae880) 63.69% compared to head (2c00669) 63.88%.

❗ Current head 2c00669 differs from pull request most recent head 16134a5. Consider uploading reports for the commit 16134a5 to get more accurate results

Files Patch % Lines
...src/main/java/sootup/java/core/views/JavaView.java 85.71% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #828      +/-   ##
=============================================
+ Coverage      63.69%   63.88%   +0.18%     
- Complexity      3435     3438       +3     
=============================================
  Files            313      313              
  Lines          15159    15136      -23     
  Branches        2568     2568              
=============================================
+ Hits            9656     9669      +13     
+ Misses          4597     4562      -35     
+ Partials         906      905       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety requested a review from kadirayk January 23, 2024 15:12
@swissiety swissiety requested a review from stschott January 24, 2024 15:41
@swissiety swissiety merged commit ee53892 into develop Jan 25, 2024
7 checks passed
@swissiety swissiety deleted the enhance/concurrencyJavaView827 branch January 25, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace stream() with parallelStream()
2 participants