Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace locals in body builder after types are resolved #877

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

guiyj
Copy link
Contributor

@guiyj guiyj commented Feb 28, 2024

At the end of TypeResolver.resolve() method, all local types are resolved, however, only the Set<Local> locals of the Body is replaced with a set of locals with types, without replacing the new locals in each statement.


This resulted in the locals in most Stmts still lacking type information after applying the TypeAssigner. This pull request fixes this issue.

Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (9716b4a) to head (a48c07d).
Report is 7 commits behind head on develop.

❗ Current head a48c07d differs from pull request most recent head 54975c8. Consider uploading reports for the commit 54975c8 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #877      +/-   ##
=============================================
+ Coverage      68.26%   68.53%   +0.27%     
- Complexity      3877     3889      +12     
=============================================
  Files            311      311              
  Lines          15186    15195       +9     
  Branches        2587     2589       +2     
=============================================
+ Hits           10366    10414      +48     
+ Misses          3911     3880      -31     
+ Partials         909      901       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…eptors/typeresolving/TypeResolver.java


change only if needed (which should be the case most of the time)
@swissiety swissiety merged commit 9e924a8 into soot-oss:develop Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants