Fix #960 ushr get type #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stschott
reviewed
Jul 8, 2024
| final PrimitiveType.FloatType aFloat = PrimitiveType.getFloat(); | ||
| if (op1t == aFloat || op2t == aFloat) { | ||
| return aFloat; | ||
| } |
There was a problem hiding this comment.
We should name the other types doubleType and floatType as well, just to stay consistent.
Also, are you sure that == is sufficient here? The types are not implemented as enums.
There was a problem hiding this comment.
but as singletons - on the other hand in theory someone could subclass them..
stschott
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #960