-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial definition of Extension namespace #503
Conversation
It looks like the checks on this may have failed due to the inclusion of an "Remote Classes" section within the extension.md property specification. |
@sbarnum - thanks for writing this up. On the remote classes, we can open a PR for the spec-parser to understand the section. Currently, the spec-parser generates a model file with OWL and SHACL and a separate JSON-LD context file. Can you document what should be added to these files? We can then update the spec-parser unless there are objections to the format. |
@sbarnum - could you also add a profile.md for Extension which describes the profile? |
I'm not sure I understood what "Remote Classes" is about. Are you saying that this PR introduces the property If yes, the way we have done it until now is to actually modify the |
Yes. This PR introduces the property 'extension' (an object property with range of |
If I understand correctly the current approach for SPDX 3.0 is to create a single monolithic OWL and SHACL file for all of SPDX. The upside of this is reduced complexity in dealing with how separate file-based namespace imports work. The downside is increased complexity in trying to validate against specific profiles that include only certain namespaces.
I am unaware of a formal decision yet on what exactly will be in the jsonld context file.
|
I am unclear where this would go and what i should use as an exemplar of what you are looking for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixes to the way we reference other namespaces, and then it can be merged.
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
It looks like the spec-parser is failing with this PR. I'll see if I can narrow down the issue. |
It looks like this is caused by having a profile by the same name as a property. I created spdx/spec-parser#82 in the spec parser. @zvr - any ideas how to fix? We could work around this by either renaming the property or renaming the profile. |
@goneall the new parser, completely rewritten from scratch, does not have such issues. |
Where is the new parser implemented? |
https://github.com/spdx/spec-parser/tree/new-parser |
@zvr - how soon before the new spec-parser is ready? I noticed it isn't processing args yet - so I wasn't able to test with this branch of the model. |
per Jeff on the call, the new spec parser issues should now be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.