Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ElementCollection to have 0 elements #552

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

JPEWdev
Copy link
Contributor

@JPEWdev JPEWdev commented Nov 9, 2023

As discussed in #526, an ElementCollection have 0 Elements is useful to prevent parties that are exchanging SPDX content from needing to have an out-of-band mechanism to indicate the case where there are no elements to be transferred.

Closes #526
Closes #551

As discussed in spdx#526, an ElementCollection have 0 Elements is useful to
prevent parties that are exchanging SPDX content from needing to have an
out-of-band mechanism to indicate the case where there are no elements
to be transferred.

Closes spdx#526
Closes spdx#551
@JPEWdev JPEWdev force-pushed the element-collection-no-element branch from 5ed030e to 3670035 Compare November 9, 2023 23:33
@kestewart
Copy link
Contributor

@zvr - can you review please.

@sbarnum
Copy link
Collaborator

sbarnum commented Nov 14, 2023

This makes sense to me.

Copy link
Collaborator

@sbarnum sbarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is consensus on this change and specific implementation.

@kestewart kestewart merged commit af876a7 into spdx:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants