Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Licensing.md: minor wording updates #558

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Update Licensing.md: minor wording updates #558

merged 3 commits into from
Nov 28, 2023

Conversation

jlovejoy
Copy link
Member

Fixed a couple missing words or other such clarifications.

Re-wrote the Summary to be less definitive regarding license compliance

Signed-off-by: Jilayne Lovejoy

Signed-off-by: Jilayne Lovejoy
@jlovejoy
Copy link
Member Author

@swinslow - please have a look. There are a couple other things that I think could be improved, including the use of "conclusion" in relation to no data, but I need to think more of a way to clarify that.

Also we have "reasonable objective" sometimes and "reasonably objective" sometimes - thinking it should be consistently the latter?

Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlovejoy, I had a couple of suggested tweaks to the edits here -- take a look and see what you think. Otherwise LGTM. Thanks!

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member

goneall commented Nov 26, 2023

Just noticed @swinslow comment - @jlovejoy - once you and Steve review/update I'll re-review and merge.

@swinslow
Copy link
Member

@jlovejoy Are you good with the further tweaks I made in 5ae17e3?

These were to address the comments above, as well as trying to avoid overloading the term "conclusion" given the presence of the concludedLicense relationship.

If these look good to you, then @goneall can merge once he's good with these as well. Thanks!

@zvr
Copy link
Member

zvr commented Nov 27, 2023

Minor wording comment: it shouldn't be "relationship to a NoneLicense" (or "NoAssertionLicense"), but "relationship to NoneLicense" (without the "a"). Both NoneLicense and NoAssertionLicense are defined individuals, there is only one of them, so the indefinite article "a" does not make sense.

More substantial comment: I know all examples talk about Packages, Files and Snippets, and the text talks about "Software Artifacts." However, this is not "SoftwareLicensing" profile and I'm pretty certain people will want to use it for non-software artifacts. Do we want to include some wording to this effect (or, conversely, explicitly mention that this is only for SoftwareArtifacts?)

@swinslow
Copy link
Member

Thanks @zvr!

More substantial comment: I know all examples talk about Packages, Files and Snippets, and the text talks about "Software Artifacts." However, this is not "SoftwareLicensing" profile and I'm pretty certain people will want to use it for non-software artifacts. Do we want to include some wording to this effect (or, conversely, explicitly mention that this is only for SoftwareArtifacts?)

Licensing, as currently envisioned, is only for SoftwareArtifacts. Several assumptions about how this is structured and how licenses work do not necessarily translate to non-software artifacts (whatever those may be). I'm good with us being more explicit about this if you think that's appropriate and helpful.

@jlovejoy
Copy link
Member Author

@swinslow @zvr @goneall - made a few updates as per @zvr suggestion of removing "a" and other wordsmithing. I think there may be some other improvements on clarity of wording, but for now, this is good to go.

@swinslow
Copy link
Member

Thank you @jlovejoy and @zvr!

@goneall I think this is ready for your re-review and merging!

@goneall goneall merged commit 0691bf5 into main Nov 28, 2023
@bact bact deleted the jlovejoy-patch-1 branch August 28, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants