-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Licensing.md: minor wording updates #558
Conversation
Signed-off-by: Jilayne Lovejoy
@swinslow - please have a look. There are a couple other things that I think could be improved, including the use of "conclusion" in relation to no data, but I need to think more of a way to clarify that. Also we have "reasonable objective" sometimes and "reasonably objective" sometimes - thinking it should be consistently the latter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jlovejoy, I had a couple of suggested tweaks to the edits here -- take a look and see what you think. Otherwise LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Steve Winslow <[email protected]>
@jlovejoy Are you good with the further tweaks I made in 5ae17e3? These were to address the comments above, as well as trying to avoid overloading the term "conclusion" given the presence of the If these look good to you, then @goneall can merge once he's good with these as well. Thanks! |
Minor wording comment: it shouldn't be "relationship to a NoneLicense" (or "NoAssertionLicense"), but "relationship to NoneLicense" (without the "a"). Both More substantial comment: I know all examples talk about Packages, Files and Snippets, and the text talks about "Software Artifacts." However, this is not "SoftwareLicensing" profile and I'm pretty certain people will want to use it for non-software artifacts. Do we want to include some wording to this effect (or, conversely, explicitly mention that this is only for SoftwareArtifacts?) |
Thanks @zvr!
Licensing, as currently envisioned, is only for SoftwareArtifacts. Several assumptions about how this is structured and how licenses work do not necessarily translate to non-software artifacts (whatever those may be). I'm good with us being more explicit about this if you think that's appropriate and helpful. |
Fixed a couple missing words or other such clarifications.
Re-wrote the Summary to be less definitive regarding license compliance
Signed-off-by: Jilayne Lovejoy