Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change range of subjectLicense to ExtendableLicense #613

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Change range of subjectLicense to ExtendableLicense #613

merged 1 commit into from
Feb 5, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 26, 2024

Fixes #612

@goneall goneall added the Profile:Licensing Licensing Profile and related matters label Jan 26, 2024
@goneall goneall added this to the 3.0-rc2 milestone Jan 26, 2024
@goneall goneall mentioned this pull request Jan 26, 2024
Closed
@goneall goneall requested review from zvr and kestewart January 26, 2024 23:20
@goneall goneall mentioned this pull request Jan 30, 2024
Closed
32 tasks
kestewart
kestewart approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kestewart kestewart requested a review from swinslow February 1, 2024 09:53
@goneall goneall requested a review from puerco February 4, 2024 18:49
@goneall
Copy link
Member Author

goneall commented Feb 4, 2024

@zvr @puerco - just need one more review to merge - can you take a look?

sbarnum
sbarnum approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@sbarnum sbarnum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on conversation with @goneall this looks to fix issues with abstraction on this range.

@goneall goneall merged commit 70776d0 into main Feb 5, 2024
1 check passed
@goneall goneall deleted the goneall-patch-2 branch February 5, 2024 15:37
@zvr zvr mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbarnum sbarnum sbarnum approved these changes

@kestewart kestewart kestewart approved these changes

@zvr zvr Awaiting requested review from zvr

@swinslow swinslow Awaiting requested review from swinslow

@puerco puerco Awaiting requested review from puerco

Assignees
No one assigned
Labels
Profile:Licensing Licensing Profile and related matters
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.

Type mismatch in ExpandedLicensing
3 participants
@goneall @sbarnum @kestewart