Fix delegatedTo Relationship #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, the definition of the delegatedTo relationship was flawed. Since it linked one agent to another, it was impossible to determine which delegatedTo relationships applied to which invokedBy relationships. To solve this, reword the delegatedTo relationship to indicated that the `to` end must point to the specific invokedBy relationships to which it applies. Signed-off-by: Joshua Watt <[email protected]>
|
It should be noted that this is an unorthodox relationship in that it relates an Actor to another Relationship, which IIRC has not been done before. However, I believe in this context is correctly conveys the information required. |
|
I have no issue with constraining the I am finding it hard to follow the scenario and intent here proposed in this PR. |
|
Here is an example that hopefully explains it a little better: https://drive.google.com/file/d/1F6MiE48PAuz8uhk8Jy-g2jCOaAdVolFX/view?usp=sharing |
kestewart
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice, the definition of the delegatedTo relationship was flawed. Since it linked one agent to another, it was impossible to determine which delegatedTo relationships applied to which invokedBy relationships.
To solve this, reword the delegatedTo relationship to indicated that the
toend must point to the specific invokedBy relationships to which it applies.