-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of 'standard' property to be 'standardName' #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the solution as well - and the PR LGTM.
Thanks @sbarnum and the participants on the tech team call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that the CI is failing - there is a class referencing standard that also needs updating. I believe it is Artifact
.
@sbarnum - if you could add that change in as well.
I just confirmed it is in the Core/Artifact class - we just need to rename |
this fails with |
this also needs to be changed in:
|
@goneall - discussed this in AI call, and we're good with it as is. For future, Karen volunteers to coordinate with IEEE/ISO for future standard fields. |
Signed-off-by: Gary O'Neall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - CI failures are now fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gary for fixing the remaining refs.
This PR implements the consensus decision of the Feb 06, 2024 Tech call to address immediate concerns under Issue #387.
More structured approaches to fully resolving Issue #387 will be pursued post RC2.