-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Identifiers for Software Artifacts #701
Conversation
Signed-off-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Alexios Zavras (zvr) <[email protected]>
Discussion on the tech call 4/9 favored removing the gitoid property in favor of this generalized type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove gitoid as it is redundant and confusing to implementers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPEWdev do you want me to do it in this PR, or do you want to approve this one and I can create a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate PR is fine, but it is a breaking 3.0 change so it needs to be resolved before release
@jeff-schutt will review after the call today then we can merge with changes above. |
Co-authored-by: Maximilian Huber <[email protected]>
This PR goes against a prior agreement, documented here:
|
It does not "go against" something discussed in 2022, since it still allows using a gitoid as a content identifier. |
Signed-off-by: Alexios Zavras (zvr) <[email protected]>
Nevermind, we did say AnyURI was OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lets a gitoid be considered a content identifier, and lets other standard content identifers that may emerge be incorporated in a structured non breaking way in future.
Discussed with Kate offline, this PR is ready to merge. |
This adds a general system for supporting various content identifiers for Software Artifacts.
It adds a new property on
SoftwareArtifact
, its class, and a vocabulary for different types of identifiers (which can be expanded in the future, with no breaking changes).This is re-work of #611