-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix all jsonld examples #762
Conversation
Signed-off-by: Maximilian Huber <[email protected]>
"element": [ | ||
"https://some.namespace#SPDXRef-Package", | ||
"https://some.namespace#File1", | ||
"https://some.namespace#file1", | ||
"https://some.namespace#file2", | ||
"https://spdx.dev/elements/3F26391C#spdx-spec-v2.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the creator "https://spdx.dev/elements/3F26391C#spdx-spec-v2.3",
is listed in "element"
of the SpdxDocument but is not contained in the file
the "profileConformance" value "licensing" causes the parser to fail -> got dropped. |
The |
Signed-off-by: Maximilian Huber <[email protected]>
There are now no examples demonstrating contentIdentifier, this should be added |
Signed-off-by: Maximilian Huber <[email protected]>
Generated with https://github.com/maxhbr/spdx3ToGraph: |
Signed-off-by: Maximilian Huber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current examples in serializaiton/json_ld/examples are all except one invalid.